Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6442 device specific heads for dynunet #6484

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

wyli
Copy link
Contributor

@wyli wyli commented May 6, 2023

Fixes #6442

Description

make self.heads safe for multi devices

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Contributor Author

wyli commented May 6, 2023

/build

@wyli wyli marked this pull request as ready for review May 6, 2023 16:13
@ericspod
Copy link
Member

ericspod commented May 6, 2023

This does produce separate heads for each device/thread, however access to the dictionary needs to be synchronized somehow for thread-safety I think. I mentioned this just now too in #6442.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynUNet crashes with DataParallel and DeepSupervision
2 participants