allow bbox in occ sens constructor #5169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Brown <[email protected]>
ericspod
approved these changes
Sep 16, 2022
wyli
reviewed
Sep 16, 2022
| @@ -298,6 +306,7 @@ def __call__(self, x: torch.Tensor, b_box: Optional[Sequence] = None) -> Tuple[t | |||
| * The most probable class when the corresponding part of the image is occluded (``argmax(dim=-1)``). | |||
| Both images will be cropped if a bounding box used, but voxel sizes will always match the input. | |||
| """ | |||
| bbox = bbox if bbox is not None else self.bbox | |||
There was a problem hiding this comment.
the method is currently using b_box
Suggested change
| bbox = bbox if bbox is not None else self.bbox | |
| bbox = b_box if b_box is not None else self.bbox |
Nic-Ma
reviewed
Sep 20, 2022
| @@ -182,6 +189,7 @@ def __init__( | |||
| self.stride = stride | |||
| self.per_channel = per_channel | |||
| self.verbose = verbose | |||
| self.bbox = bbox | |||
There was a problem hiding this comment.
Please make the doc-string and code in consistent: "bbox" vs "b_box".
I would suggest b_box as the existing arg is b_box.
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If bounding box is always the same, it makes sense to give the user the option to set it in the constructor.
If bbox given in
__call__method use that. Else use bbox given in constructor. Else useNone.Types of changes