Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverse Rand2DElasticd and Rand3DElasticd #1793

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

rijobro
Copy link
Contributor

@rijobro rijobro commented Mar 17, 2021

Inverse Rand2DElasticd and Rand3DElasticd.

part of #1515

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@rijobro rijobro requested review from wyli, ericspod and Nic-Ma March 17, 2021 16:43
@rijobro
Copy link
Contributor Author

rijobro commented Mar 17, 2021

requires #1781.

@rijobro rijobro force-pushed the inverse_RandElasticd branch from ad48da1 to 9e65010 Compare March 18, 2021 08:58
@rijobro rijobro added the enhancement New feature or request label Mar 18, 2021
@rijobro rijobro mentioned this pull request Mar 19, 2021
6 tasks
@wyli
Copy link
Contributor

wyli commented Mar 29, 2021

Hi @rijobro sorry for the delay, we may not have time to review/include this in v0.5.0, is it fine to postpone this PR?

@rijobro
Copy link
Contributor Author

rijobro commented Mar 29, 2021

Sure, no rush on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants