Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setting modal 구현 #71

Merged
merged 12 commits into from
Jul 25, 2024
Merged

feat: setting modal 구현 #71

merged 12 commits into from
Jul 25, 2024

Conversation

hoongding
Copy link
Contributor

📖 관련 문서

ex. 노션, Figma, 이슈 링크


Closes 뒤에 본 PR을 머지하면 close할 issue number를 적어주세요.

✍🏻 변경사항:

ex. 중요 커밋은 링크로 연결해서 추가

🔍 확인할 목록

  • sidebar 메뉴 이름 enum으로 변경 했습니다.
  • setting 관련 모달 구현 완료했습니다.
  • 계정 삭제 api 연결 했습니다!

@hoongding hoongding requested a review from bbung95 July 24, 2024 13:07
@hoongding hoongding self-assigned this Jul 24, 2024
Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
packit-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 2:24pm

Copy link

🚀 Storybook 자동 배포 URL: https://6637bd73cba78215aa6e39fa-fcqcgxaguv.chromatic.com/

Copy link
Member

@bbung95 bbung95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와우 고생하셨습니다!! Enum 좋습니다!

모달 dim 클릭시에 닫히지 않는거 같아요! 그 부분만 확인부탁드리겠습니다!

@hoongding hoongding merged commit 1f2cadc into main Jul 25, 2024
2 of 3 checks passed
Copy link

🚀 Storybook 자동 배포 URL: https://6637bd73cba78215aa6e39fa-qmhemuvhos.chromatic.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants