Feat/home page #57
Feat/home page #57
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
🚀 Storybook 자동 배포 URL: https://6637bd73cba78215aa6e39fa-aaavowoxta.chromatic.com/ |
|
🚀 Storybook 자동 배포 URL: https://6637bd73cba78215aa6e39fa-lfjkuldmft.chromatic.com/ |
|
🚀 Storybook 자동 배포 URL: https://6637bd73cba78215aa6e39fa-jzoajlzlub.chromatic.com/ |
bbung95
added
✨ feat
|
🚀 Storybook 자동 배포 URL: https://6637bd73cba78215aa6e39fa-zzqfnwwomj.chromatic.com/ |
| <div | ||
| className={cn([ | ||
| 'h-fit w-fit overflow-hidden rounded-xl', | ||
| 'group-hover:shadow-layer group-hover:-translate-y-8 transition-all duration-200', |
There was a problem hiding this comment.
p99;
세상에,,, group hover가 있군요,,,
| <img | ||
| className='rounded-full' | ||
| src={faviconUrl} | ||
| alt='' |
| </picture> | ||
| <span className='body-md text-text truncate'>{siteName}</span> | ||
| <div className='absolute right-0 hidden items-center gap-12 bg-surface *:text-icon-minimal group-hover:flex'> | ||
| <button onClick={(e) => e.stopPropagation()}> |
There was a problem hiding this comment.
p3;
이쪽 나중에 handleClick으로 바꿔서 공통되는 코드 제거해도 좋을 것 같습니다~
src/components/Sidebar/index.tsx
Outdated
| @@ -121,7 +129,7 @@ const SideBar = () => { | |||
| {isOpenSidebar && ( | |||
| <div className='px-12 py-[5px] body-sm-bold text-secondary'>리소스</div> | |||
| )} | |||
| <Menu> | |||
| <Menu onClick={() => handleNewWindowLink('https://forms.gle/dPi5voXeF3Fh7jve9')}> | |||
There was a problem hiding this comment.
p3;
handleNewWindowLink내의 url constant value로 빼서 주입해도 좋을 것 같아요!
| </div> | ||
| </label> | ||
| ) : ( | ||
| <div | ||
| className='cursor-pointer w-full h-full flex justify-center items-center' | ||
| onClick={() => handleDeleteFile(files[0].key)} | ||
| > | ||
| {files[0].name} | ||
| <img className='aspect-[300/180] object-cover' src={String(files[0].src)} alt='' /> |
There was a problem hiding this comment.
p3;
여기도 alt 추가하면 좋을 것 같습니당!
|
🚀 Storybook 자동 배포 URL: https://6637bd73cba78215aa6e39fa-fsddgydnyf.chromatic.com/ |
📖 관련 문서
validation
https://formik.org/docs/api/useFormik
https://github.com/jquense/yup
✍🏻 변경사항:
🔍 확인할 목록