Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/스토리북 아이콘 갤러리 작업 #33

Merged
merged 4 commits into from
May 6, 2024
Merged

Conversation

rai-95
Copy link
Contributor

@rai-95 rai-95 commented May 6, 2024

📖 관련 문서

#32 close

https://storybook.js.org/docs/api/doc-block-icongallery

✍🏻 변경사항:

스크린샷 2024-05-07 오전 1 01 07

  • 아이콘 확인이 어려워서 아이콘 갤러리 추가했습니다!
  • 기본 사이즈와 컬러 추가했습니다!

🔍 확인할 목록

[ ] 스토리북 아이콘 갤러리 확인

@rai-95 rai-95 requested a review from hoongding May 6, 2024 16:05
@rai-95 rai-95 self-assigned this May 6, 2024
@rai-95 rai-95 linked an issue May 6, 2024 that may be closed by this pull request
Copy link

github-actions bot commented May 6, 2024

🚀 Storybook 자동 배포 URL: https://6637bd73cba78215aa6e39fa-oikusisjgn.chromatic.com/

@rai-95 rai-95 added ✅ test 테스트 코드만 변경됩니다. 🎨 style UI 관련 이슈입니다. labels May 6, 2024
Copy link
Contributor

@hoongding hoongding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

성은님 좋습니다!
혹시 이 브랜치에서 Icon currentColor로 변경 가능할까요?

Copy link

github-actions bot commented May 6, 2024

🚀 Storybook 자동 배포 URL: https://6637bd73cba78215aa6e39fa-qhtesjipyv.chromatic.com/

Copy link
Contributor

@hoongding hoongding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다 성은님~ 머지 가시죵~

@rai-95 rai-95 merged commit c546faa into main May 6, 2024
3 checks passed
@bbung95 bbung95 assigned bbung95 and unassigned rai-95 Jun 12, 2024
@hoongding hoongding deleted the feat/common-icon branch July 13, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 style UI 관련 이슈입니다. ✅ test 테스트 코드만 변경됩니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design: 스토리북 아이콘 갤러리
3 participants