Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding guidelines. Updating README #213

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Adding guidelines. Updating README #213

merged 2 commits into from
Feb 2, 2024

Conversation

asanzo
Copy link
Contributor

@asanzo asanzo commented Feb 2, 2024 •
edited
Loading

@asanzo asanzo requested a review from a team as a code owner February 2, 2024 18:09
@asanzo asanzo requested a review from rgonzalezt February 2, 2024 18:09
@asanzo asanzo mentioned this pull request Feb 2, 2024
Merged
rgonzalezt
rgonzalezt approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@rgonzalezt rgonzalezt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Está genial, sólo esas dos dudas

CODE_OF_CONDUCT.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sabes que me gustaría eventualmente? Que alguien de género pueda verlo o tratar de arreglarlo nosotres.
Ya el texto comienza con "Nosotros, como miembros, contribuyentes y administradores nos comprometemos...".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tenés razón. Lo podemos hacer nosotros. No sé qué días viene Lu. Está así porque es una copia de un contribution guidelines base que hay en inet (en la versión en inglés están los links).

README.md
_____________

### Release & deploy (Solo para el equipo de Pilas Bloques)
https://github.com/Program-AR/pilas-bloques-ember/wiki/Release-y-Deploy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

por ahora ese link queda en ember?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sí, creo que en otro paso lo revisaría / reescribiría. Podemos abrir una Wiki en app y pasar las cosas que sirvan. Querés crearte un issue porfa? Que sea revisar la wiki de ember y pasar, y recordar esto.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

listo!! #214

@asanzo asanzo merged commit be652c8 into develop Feb 2, 2024
10 checks passed
@asanzo asanzo deleted the bureaucracy branch February 2, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgonzalezt rgonzalezt rgonzalezt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Orden repos: Burocracia Readmes y Licencias
2 participants
@asanzo @rgonzalezt