Hawk/dove batch run code for data analysis #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 63.53% 63.66% +0.13%
==========================================
Files 16 16
Lines 820 823 +3
==========================================
+ Hits 521 524 +3
Misses 299 299 |
rlskoeser
force-pushed
the
hawkdove-batchrun
branch
from
9382923 to
180fe48
Compare
laurejt
requested changes
Jan 18, 2024
| simrisk-hawkdovemulti-batchrun --iterations 1 --max-step 125 --no-progress | ||
|
|
||
| # longer run: one iteration, max of 125 steps, no progress bar | ||
| # (typically completes in less than 15 minutes) |
There was a problem hiding this comment.
Either remove this line or provide an estimate of how long 10 iterations typically takes
Suggested change
| # (typically completes in less than 15 minutes) |
There was a problem hiding this comment.
I haven't figure out that estimate yet for the current config (I tweaked the parameter set), but I probably need to for my own batch running anyway - do you think it's worth including some time estimates here?
There was a problem hiding this comment.
Not really, unless the extrapolation of 150 minutes (10 * 15) is really off
Comment on lines
34
to
50
| 3000 in one minute | ||
|
|
||
| 8100 with one iteration | ||
|
|
||
| try with larger max step? | ||
|
|
||
|
|
||
| 81000 with ten iterations | ||
|
|
||
| 3000 | ||
|
|
||
| 8100 with one iteration, 125 max step | ||
| 00:11:03 | ||
|
|
||
|
|
||
| 10 iterations, 125 steps, 2 hours = 66395 runs | ||
|
|
There was a problem hiding this comment.
Should these notes be included?
There was a problem hiding this comment.
hahaha, whoops! nope, will clean that up
Co-authored-by: Laure Thompson <[email protected]>
Co-authored-by: Laure Thompson <[email protected]>
Co-authored-by: Laure Thompson <[email protected]>
Co-authored-by: Laure Thompson <[email protected]>
Co-authored-by: Laure Thompson <[email protected]>
laurejt
reviewed
Jan 23, 2024
laurejt
approved these changes
Jan 23, 2024
rlskoeser
added a commit
that referenced
this pull request
Feb 12, 2024
* Suppress convergence print statement for batch runs * Customize risk category string output for batch run data collection * Custom batch runner for hawk/dove multi risk sim * Configure hawk/dove multi batch run to be installed as a script * Step argument needs to be an integer also * Revise multiprocessing based on slurm cpu efficiency report * Correct basic hawk/dove readme for scope * Use configured neighborhood sizes; correct typo in help string * Add file prefix option for generated data files * Turn random play odds completely off by default * Add readme for hawk/dove multi risk game; document batch running * Add sample batch run slurm script * Update simulatingrisk/hawkdove/model.py Co-authored-by: Laure Thompson <[email protected]> * Update simulatingrisk/hawkdovemulti/README.md Co-authored-by: Laure Thompson <[email protected]> * Update simulatingrisk/hawkdovemulti/batch_run.py Co-authored-by: Laure Thompson <[email protected]> * Update simulatingrisk/hawkdovemulti/simrisk_batch.slurm Co-authored-by: Laure Thompson <[email protected]> * Update simulatingrisk/hawkdovemulti/batch_run.py Co-authored-by: Laure Thompson <[email protected]> * Cleanup items flagged by @laurejt in code review * Set file prefix default in argparse for consistency * Document step offset between scheduler and data collection * Better documentation for sample slurm batch script --------- Co-authored-by: Laure Thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in this PR:
revisions after review
add more estimates for batch run & document(postponing since this will change pending other planned revisions)