Give up on testing logging; add comments

Princeton-CDH · Nov 11, 2024 · 45b9248 · 45b9248
1 parent ceeef53
commit 45b9248
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/ppa/archive/tests/test_gale.py b/ppa/archive/tests/test_gale.py
@@ -321,7 +321,10 @@ def test_get_item_pages(self, mock_get_item, mock_get_local_ocr, mockrequests):
             "more test content",
             "fallback gale text",
         ]
-        # TODO: check logging
+        # NOTE: would be nice to test logging, but can't get
+        # pytest caplog or unittest logging assertions to work
+        # since the logging is already captured and displayed by the
+        # test runner
 
         # confirm json decode error is handled appropriately
         mock_get_local_ocr.side_effect = json.decoder.JSONDecodeError(
@@ -333,7 +336,7 @@ def test_get_item_pages(self, mock_get_item, mock_get_local_ocr, mockrequests):
             "more test content",
             "fallback gale text",
         ]
-        # TODO: check logging
+        # would be nice to test logging here also
 
         # skip api call if record is provided
         mock_get_item.reset_mock()