feat: Update to latest library versions #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| secureStationURL.SetSID(1) | ||
| secureStationURL.SetStream(10) | ||
| secureStationURL.SetType(2) | ||
| secureStationURL.SetPortNumber(uint16(port)) |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types High
ashquarky
approved these changes
Feb 21, 2025
| metaBinary.CreationTime.FromTimestamp(time.Unix(creationTimestamp, 0)) | ||
| metaBinary.UpdatedTime.FromTimestamp(time.Unix(updatedTimestamp, 0)) | ||
| metaBinary.ReferredTime.FromTimestamp(time.Unix(referredTimestamp, 0)) | ||
| metaBinary.ExpireTime.FromTimestamp(time.Unix(expireTimestamp, 0)) |
There was a problem hiding this comment.
I still think this is silly behavior for this function. Code's valid though
| tags[i] = string(tag) | ||
| } | ||
|
|
||
| extraDatas := make([]string, len(dataStorePreparePostParam.ExtraData)) |
There was a problem hiding this comment.
Might want an upper-bound length check here?
That's just what the original code did, nothing in its behavior has been changed or removed. There is room for improvement once we get common DataStore, but that is outside the scope of the migration (This also answers the review comments) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1
Changes:
Needs more testing, seems to have issues