Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to nex-go rewrite #3

Merged
merged 7 commits into from
Feb 12, 2025
Merged

Update to nex-go rewrite #3

merged 7 commits into from
Feb 12, 2025

Conversation

DaniElectra
Copy link
Member

Resolves #1

Changes:

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2025

CLA assistant check
All committers have signed the CLA.

secureStationURL := types.NewStationURL("")
secureStationURL.SetURLType(constants.StationURLPRUDPS)
secureStationURL.SetAddress(os.Getenv("PN_LM2_SECURE_SERVER_HOST"))
secureStationURL.SetPortNumber(uint16(port))

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types High

Incorrect conversion of an integer with architecture-dependent bit size from
strconv.Atoi
to a lower bit size type uint16 without an upper bound check.
Incorrect conversion of an integer with architecture-dependent bit size from
strconv.Atoi
to a lower bit size type uint16 without an upper bound check.
Copy link
Member

@jonbarrow jonbarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonbarrow jonbarrow merged commit ab0de9f into master Feb 12, 2025
4 of 5 checks passed
@binaryoverload binaryoverload deleted the nex-go-rewrite branch February 15, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Update to v2 NEX libraries
4 participants