Added queue clearing #170
Added queue clearing #170
Conversation
JavaScript events considered: - updateCart - changedCheckoutStep - updatedProduct - updateProductList
controllers/front/ajax.php
Outdated
| /** | ||
| * @var Ps_Googleanalytics | ||
| */ | ||
| public $module; |
There was a problem hiding this comment.
Is this necessary? I think it should be automatic when you are extending ModuleFrontController.
There was a problem hiding this comment.
No, it's not necessary; I added it to make the type explicit, i.e., "Ps_Googleanalytics", so that there are no warnings in the editor.
However, if you consider it "redundant", I can remove it.
There was a problem hiding this comment.
Just remove this please, your IDE complains because it lacks the context of a parent class. :-)
Co-authored-by: Nicolas Lœuillet <[email protected]>
|
@Hlavtox, |
|
awesome, waiting for merge |
|
@Hlavtox, have you had a chance to review this PR? Also, if it's okay, I could create a second PR with the changes related to updating the product list (e.g., on the category page when filtering). Thanks, and sorry for bothering you. |
There was a problem hiding this comment.
One comment but I think its good.
ping @kpodemski for check
controllers/front/ajax.php
Outdated
| /** | ||
| * @var Ps_Googleanalytics | ||
| */ | ||
| public $module; |
There was a problem hiding this comment.
Just remove this please, your IDE complains because it lacks the context of a parent class. :-)
JavaScript events considered: