-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix date formatting #945
Fix date formatting #945
Conversation
@florine2623 Added some steps to reproduce. :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Hlavtox ,
I can't see the new date format 😞
I have followed your steps. Also, cleared cache from PS and from browser as well. The old format is still displayed.
Am I missing something ? ^^
Yes, just the fact that you don't have any errors makes this QA ✅. :-) |
Yes indeed, the date format changes on your country. I didn't think about that, sorry ^^ |
What is wrong
The method Tools::displayDate was changed between 1.7.8 and 8.0.0, and this module was calling the old version, resulting in some errors in developer mode.
https://github.com/PrestaShop/PrestaShop/blob/1951311beb2497bb97659aded1b643905403becc/classes/Tools.php#L981
https://github.com/PrestaShop/PrestaShop/blob/f64f657366caf66e01f3b4fccaad4b77989a1257/classes/Tools.php#L923
How to test (do these steps on both versions)