-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add upload, install and uninstall endpoints #37
Merged
jolelievre
merged 7 commits into
PrestaShop:dev
from
jolelievre:install-uninstall-module
Nov 8, 2024
Merged
Add upload, install and uninstall endpoints #37
jolelievre
merged 7 commits into
PrestaShop:dev
from
jolelievre:install-uninstall-module
Nov 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jolelievre
commented
Nov 5, 2024
Questions | Answers |
---|---|
Description? | Add upload, install and uninstall endpoints |
Type? | new feature |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | Fixes PrestaShop/PrestaShop#36976, Fixes PrestaShop/PrestaShop#36975 |
Sponsor company | ~ |
How to test? | ~ |
jolelievre
force-pushed
the
install-uninstall-module
branch
from
November 5, 2024 16:19
6c1978b
to
0a898bd
Compare
This was referenced Nov 5, 2024
Closed
… a custom ModuleGridDataFactory
…and the workflow to upload install and uninstall a module
jolelievre
force-pushed
the
install-uninstall-module
branch
from
November 5, 2024 16:26
0a898bd
to
0dca4b7
Compare
…tional fields, improve Module API endpoints tests including error cases
nicosomb
approved these changes
Nov 8, 2024
tleon
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some Ci tests are broken
@tleon yep because develop branch is not up to date yet and doesn't have the required modifications and CQRS commands added on 9.0.x It will work later when the develop branch is updated, but these workflows are not blocking for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.