Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted SCSS Styling to Tailwind in EmptyView.jsx and cart.jsx Main Container #91

Conversation

Rucha-Ambaliya
Copy link
Contributor

Fixes Issue🛠️

Closes #64

Description👨‍💻

EmptyView.jsx:

  • Converted styling from SCSS to Tailwind CSS. Replaced custom CSS with Tailwind's utility classes for layout, spacing, and responsiveness.

cart.jsx:

  • Updated the main container in cart.jsx to use Tailwind CSS. This indirectly affects the styling of EmptyView.jsx since it is part of the main container.

Testing

  • Installed the Edge Responsive Tester extension to test responsiveness for smaller screen sizes.
  • Verified that the styles are correctly applied across various screen sizes and the component is properly rendered with Tailwind utilities.

Type of Change📄

  • Style (non-breaking change which improves website style or formatting)
  • Responsiveness (non-breaking change which improves UI/UX on different screen sizes)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷

Screenshot 2025-01-07 234802
Screenshot 2025-01-07 234728

Copy link

vercel bot commented Jan 7, 2025

@Rucha-Ambaliya is attempting to deploy a commit to the Pratik0112's projects Team on Vercel.

A member of the Team first needs to authorize it.

@PratikMane0112
Copy link
Owner

Hey @Rucha-Ambaliya thanks also delete the unnecessary "scss file & imports " which you have converted to tailwind and run it locally, then I will merge your PR

@PratikMane0112
Copy link
Owner

Please also do check the footer.jsx it also has been converted to tailwind and also use colors in tailwind.config file & add screen shots of your page in mobile as well as desktop view

@Rucha-Ambaliya
Copy link
Contributor Author

I’ll check, and if none of the classes are being used elsewhere, I’ll delete the file accordingly. I’ll also review Footer.jsx and include its screenshots here.

@Rucha-Ambaliya Rucha-Ambaliya force-pushed the feature/convert-styling-of-EmptyView.jsx branch from 761100c to c3bf25f Compare January 8, 2025 05:21
@Rucha-Ambaliya
Copy link
Contributor Author

Recording.2025-01-08.103552.1.mp4

@PratikMane0112
Copy link
Owner

Hey @Rucha-Ambaliya, good !!!!

@PratikMane0112 PratikMane0112 merged commit 257b0fb into PratikMane0112:master Jan 8, 2025
1 check failed
@Rucha-Ambaliya
Copy link
Contributor Author

Thanks!

@Rucha-Ambaliya Rucha-Ambaliya deleted the feature/convert-styling-of-EmptyView.jsx branch January 8, 2025 08:39
Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
telmedsphere-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 11:06am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding series of PR's to convert SCSS into Tailwind CSS
2 participants