Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create privacy policy page with attractive and responsive UI (Closes #237) #238

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

Harshit457
Copy link
Contributor

Fixes Issue🛠️

Closes #237

Description👨‍💻

  • Created a new Privacy Policy page that matches the existing UI theme.
  • Ensured proper layout, using light colors and purple-blue text for consistency.
  • Added a section for an image on the left side to make the page visually appealing.
  • Created a new route /privacy for easy access to the Privacy Policy.
  • Added a Privacy Policy button in the footer for quick navigation.
  • Made the page responsive to ensure it looks great on different screen sizes.

Type of Change📄

  • New feature (non-breaking change which adds functionality)
  • Style (non-breaking change which improves website style or formatting)
  • Documentation (non-breaking change which updates or adds documentation)
  • Responsiveness (non-breaking change which improves UI/UX on different screen sizes)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas
  • I have installed packages from frontend folder by npm ci instead of npm i

Screenshots/GIF📷

📌 **Screenshot 1: **
privacy policy 1

📌 Screenshot 2: Footer with Privacy Policy Button
footer with privacy policy

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Harshit457, Welcome to 💖TelMedSphere !!! 🎊
Thanks for raising a PR! Your effort makes this project better. 🙌
Please wait for the PR to be reviewed.
Happy Coding!! ✨

Copy link

vercel bot commented Feb 4, 2025

@Harshit457 is attempting to deploy a commit to the Pratik0112's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Owner

@PratikMane0112 PratikMane0112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Plz avoid doing npm i instead do npm ci while commit, it gets added unnecessary stuff to package-lock.json
  • Rest all UI is good

frontend/package-lock.json Outdated Show resolved Hide resolved
@Harshit457
Copy link
Contributor Author

  • Plz avoid doing npm i instead to npm ci while commit, it gets added unnecessary stuff to package-lock.json
  • You can also make a checkbox to accept or terms & conditions
  • Rest all UI is good
  • Plz avoid doing npm i instead do npm ci while commit, it gets added unnecessary stuff to package-lock.json
  • You can also make a checkbox to accept or terms & conditions
  • Rest all UI is good

Sure I will do the changes please add level label on the issue and PR

@PratikMane0112
Copy link
Owner

Sure I will do the changes please add level label on the issue and PR

Sure, level will added after merge

@PratikMane0112
Copy link
Owner

You can also add below points -

  • Google OAuth Authorization
  • Also some extra points for doctor & patients data (explore website or Readme)
  • No need to make the checkbox (ignore my prev comment)

@Harshit457
Copy link
Contributor Author

Screenshot 2025-02-04 204536
I have added details of Patient and Doctor by taking reference from readme and website and also added the google OAuth Authorization part and this time i didnt do any changes in package.lock.json

Copy link
Owner

@PratikMane0112 PratikMane0112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I know you have not change package.json & package0lock.json but

  • When you install packages with npm i it gets changed (instead do npm ci )
  • When you do git add . it will affect (instead do git add only_changed_files)

frontend/package.json Outdated Show resolved Hide resolved
frontend/package-lock.json Outdated Show resolved Hide resolved
@Harshit457
Copy link
Contributor Author

@PratikMane0112 please check this now refer to the latest commit

Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pratik0112-telmedsphere ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:48pm
telmedsphere-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:48pm

Copy link

github-actions bot commented Feb 4, 2025

@Harshit457 Congrats, Your pull request has been successfully merged 🥳🎉
Thank you for your contribution to 💖TelMedSphere !!!
Happy coding 🎊, Keep Contributing 🙌 !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Privacy Policies in footer with privacy policies popup
2 participants