-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create privacy policy page with attractive and responsive UI (Closes #237) #238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Harshit457, Welcome to 💖TelMedSphere !!! 🎊
Thanks for raising a PR! Your effort makes this project better. 🙌
Please wait for the PR to be reviewed.
Happy Coding!! ✨
@Harshit457 is attempting to deploy a commit to the Pratik0112's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Plz avoid doing
npm i
instead donpm ci
while commit, it gets added unnecessary stuff topackage-lock.json
- Rest all UI is good
Sure I will do the changes please add level label on the issue and PR |
Sure, level will added after merge |
You can also add below points -
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I know you have not change package.json
& package0lock.json
but
- When you install packages with
npm i
it gets changed (instead donpm ci
) - When you do
git add .
it will affect (instead dogit add only_changed_files
)
@PratikMane0112 please check this now refer to the latest commit |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Harshit457 Congrats, Your pull request has been successfully merged 🥳🎉 |
Fixes Issue🛠️
Closes #237
Description👨💻
/privacy
for easy access to the Privacy Policy.Type of Change📄
Checklist✅
frontend
folder bynpm ci
instead ofnpm i
Screenshots/GIF📷
📌 **Screenshot 1: **
![privacy policy 1](https://private-user-images.githubusercontent.com/149406032/409540917-240b9fbb-3649-404f-be85-5dee671a9cd1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNTY3NDYsIm5iZiI6MTczOTM1NjQ0NiwicGF0aCI6Ii8xNDk0MDYwMzIvNDA5NTQwOTE3LTI0MGI5ZmJiLTM2NDktNDA0Zi1iZTg1LTVkZWU2NzFhOWNkMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQxMDM0MDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02NWNjNGVjZjU5Y2RiNjg0NTlkZDVkNTk0OTQyZmQ1MDMzYzgyNzQ1NjA0N2EwZjU2YmZhOThjNjI2ZTAyYTk0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.SXW2N4XSiwAlnZC7dc22jy8ufaZ35NcEL7MoyZxQGXg)
📌 Screenshot 2: Footer with Privacy Policy Button
![footer with privacy policy](https://private-user-images.githubusercontent.com/149406032/409540897-43391e85-6737-4e9b-ab67-7eb316cd05ec.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNTY3NDYsIm5iZiI6MTczOTM1NjQ0NiwicGF0aCI6Ii8xNDk0MDYwMzIvNDA5NTQwODk3LTQzMzkxZTg1LTY3MzctNGU5Yi1hYjY3LTdlYjMxNmNkMDVlYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQxMDM0MDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xYjZlMDdiMTEzZGIxMzhlMzMzMzVlNDU3MDA2YjZiOWNmNGE1YmE1MDJkZDdmNmM1ZDU1ODVhYWQ1NjBlMTczJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.7-Dy7eBtH-pC1yk970MNm-zLjfGPUx_lRCMKq1P_0Zk)