Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added darkmode #233

Closed
wants to merge 1 commit into from
Closed

Conversation

Shiv10122003
Copy link

@Shiv10122003 Shiv10122003 commented Feb 3, 2025

Fixes Issue🛠️

Closes #155

Description👨‍💻

Type of Change📄

  • Bug fix (non-breaking change which fixes a bug)
  • New feature (non-breaking change which adds functionality)
  • Style (non-breaking change which improves website style or formatting)
  • Documentation (non-breaking change which updates or adds documentation)
  • Responsiveness (non-breaking change which improves UI/UX on different screen sizes)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas
  • I have installed packages from frontend folder by npm ci instead of npm i

Screenshots/GIF📷

Copy link

vercel bot commented Feb 3, 2025

@Shiv10122003 is attempting to deploy a commit to the Pratik0112's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Shiv10122003, Welcome to 💖TelMedSphere !!! 🎊
Thanks for raising a PR! Your effort makes this project better. 🙌
Please wait for the PR to be reviewed.
Happy Coding!! ✨

Copy link
Owner

@PratikMane0112 PratikMane0112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Avoid raising PR from your master branch
  • Raise PR from new branch
  • Better to try it out locally for a page or component
  • Its better to create new PR from new branch & required updates from recent change

@@ -166,6 +179,12 @@ const Header = () => {
>
Register
</button>
<button
onClick={() => setDarkMode(!darkMode)}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change only logos not theme of any components

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sir should I commit frommainbranch

Copy link

github-actions bot commented Feb 3, 2025

Hello @Shiv10122003, your PR #233 has been closed without merging. 😞
Don't be discouraged! Please feel free to look into another issue of your interest or create one.
Thank you for your effort and interest in 💖TelMedSphere !!! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dark mode
2 participants