-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added darkmode #233
added darkmode #233
Conversation
@Shiv10122003 is attempting to deploy a commit to the Pratik0112's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Shiv10122003, Welcome to 💖TelMedSphere !!! 🎊
Thanks for raising a PR! Your effort makes this project better. 🙌
Please wait for the PR to be reviewed.
Happy Coding!! ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Avoid raising PR from your master branch
- Raise PR from new branch
- Better to try it out locally for a page or component
- Its better to create new PR from new branch & required updates from recent change
@@ -166,6 +179,12 @@ const Header = () => { | |||
> | |||
Register | |||
</button> | |||
<button | |||
onClick={() => setDarkMode(!darkMode)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will change only logos not theme of any components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sir should I commit frommainbranch
Hello @Shiv10122003, your PR #233 has been closed without merging. 😞 |
Fixes Issue🛠️
Closes #155
Description👨💻
Type of Change📄
Checklist✅
frontend
folder bynpm ci
instead ofnpm i
Screenshots/GIF📷