Fixed InDesiredState in PSAdapter Test operations #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anmenaga you need to add the new version of cc to our CFS feed |
SteveL-MSFT
requested changes
Oct 3, 2024
| })) | ||
|
|
||
| // Special case for PSAdapters - Test operation in them returns a single 'InDesiredState' property | ||
| if (resource.resource_type == "Microsoft.DSC/PowerShell") |
There was a problem hiding this comment.
I don't like special casing resources. I would prefer we wait until resources can propagate metadata and passes up a inDesiredState boolean which would be used universally
There was a problem hiding this comment.
ok; As discusses this will be implemented after #467 using metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #284
Adding a special case to
dsc.exeto set top-levelInDesiredStateresult from same field returned from PSAdapter.