Tree-sitter grammar for expressions #222
Conversation
|
Going to merge this so I can move forward with using it. If there's any feedback on these changes, we can address them in a separate PR. |
| "src" | ||
| ], | ||
| "sources": [ | ||
| "bindings/node/binding.cc", |
There was a problem hiding this comment.
Do you intentionally include the node bindings and this file? They are not used when using tree-sitter with Rust.
| $.expression, | ||
| $.stringLiteral, | ||
| ), | ||
| escapedStringLiteral: $ => token(seq('[[', /.*/)), |
There was a problem hiding this comment.
What if the string is not closed with ]]?
There was a problem hiding this comment.
As far as I can tell from ARM docs, it's only that start to indicate it's not an expression. There isn't a corresponding closing ]]
There was a problem hiding this comment.
However, it looks like I did miss a test case [test] string should just be a string
| number: $ => /\d+/, | ||
| boolean: $ => choice('true', 'false'), | ||
| _members: $ => repeat1($._member), | ||
| _member: $ => seq('.', $.memberName), |
There was a problem hiding this comment.
A member should be in the format <target>.<member-name>
There was a problem hiding this comment.
<target> is only ever the return value of a function
| function: $ => seq($.functionName, '(', optional($._arguments), ')'), | ||
| functionName: $ => /[a-zA-Z]+/, | ||
| _arguments: $ => seq($._argument, repeat(seq(',', $._argument))), | ||
| _argument: $ => choice($.function, $.string, $.number, $.boolean), |
There was a problem hiding this comment.
Can argument be a member expression? Like [funcA(funcB().member)].
| _arguments: $ => seq($._argument, repeat(seq(',', $._argument))), | ||
| _argument: $ => choice($.function, $.string, $.number, $.boolean), | ||
| string: $ => seq("'", /[^']*/, "'"), | ||
| number: $ => /\d+/, |
There was a problem hiding this comment.
Maybe need to take into account decimal too.
There was a problem hiding this comment.
Best I can tell, decimals are not supported
PR Summary
ARM expressions are used as values of JSON properties:
{ "foo": "[function(arg1, arg2)]" }They are identified by the square brackets. To have a literal square bracket as a string instead of an expression, you need to double it:
[[this is just a string]which would be used as[this is just a string]. Anything else would be treated as a string literal.Function args can take other functions. Strings passed to functions need to be surrounded by single-quotes.
Functions can return JSON objects which can be accessed by dot-notation:
[functionReturnObject().prop1.prop2].Tree-sitter grammar for expressions in DSC (as defined by ARM)
Includes the generated source code as it only needs to be generated if the grammar changes. Since this is generated code, having it as
uncleanas clippy complains.The only files worth reviewing (as they aren't generated) is
grammar.jsand the two test.txtfiles