Merge pull request #3563 from Portkey-Wallet/feature/revamp-ext-swap #4318
thomas-portkeyAnnotations
10 errors and 22 warnings
|
lint:
packages/mobile-app-did/js/api/list.ts#L41
Replace `typeof·EXPAND_APIS` with `(typeof·EXPAND_APIS)`
|
|
lint:
packages/mobile-app-did/js/components/ButtonCol/index.tsx#L1
'darkColors' is defined but never used
|
|
lint:
packages/mobile-app-did/js/components/ButtonCol/index.tsx#L2
'GStyles' is defined but never used
|
|
lint:
packages/mobile-app-did/js/components/CommonAvatar/index.tsx#L5
'StyleSheet' is defined but never used
|
|
lint:
packages/mobile-app-did/js/components/CommonAvatar/index.tsx#L134
'theme' is defined but never used. Allowed unused args must match /^_/u
|
|
lint:
packages/mobile-app-did/js/components/CommonButton/index.tsx#L53
'size' is assigned a value but never used
|
|
lint:
packages/mobile-app-did/js/components/CommonButton/style.ts#L6
'font4' is assigned a value but never used
|
|
lint:
packages/mobile-app-did/js/components/CommonButton/style.ts#L6
'primaryColor' is assigned a value but never used
|
|
lint:
packages/mobile-app-did/js/components/CommonButton/style.ts#L6
'bg14' is assigned a value but never used
|
|
lint:
packages/mobile-app-did/js/components/CommonToast/index.tsx#L70
'show' is assigned a value but never used
|
|
lint
Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@v2. Please update your workflow to use either v3 or v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
|
|
lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
lint:
packages/web-extension-did/app/web/components/Transaction/index.tsx#L122
React Hook useCallback has a missing dependency: 'closeFun'. Either include it or remove the dependency array
|
|
lint:
packages/web-extension-did/app/web/components/Transaction/index.tsx#L206
React Hook useCallback has an unnecessary dependency: 'renderStatusIcon'. Either exclude it or remove the dependency array
|
|
lint:
packages/web-extension-did/app/web/components/Transaction/index.tsx#L753
React Hook useCallback has a missing dependency: 'activityItem.isSystem'. Either include it or remove the dependency array
|
|
lint:
packages/web-extension-did/app/web/pages/Collection/index.tsx#L40
React Hook useCallback has missing dependencies: 'caAddressInfos', 'currentCollection.itemCount', 'fetchAccountNFTItem', 'state.chainId', and 'state.symbol'. Either include them or remove the dependency array
|
|
lint:
packages/web-extension-did/app/web/pages/Collection/index.tsx#L44
React Hook useEffect has a missing dependency: 'getNFTItems'. Either include it or remove the dependency array
|
|
lint:
packages/web-extension-did/app/web/pages/Guardians/GuardiansView/index.tsx#L353
React Hook useMemo has a missing dependency: 'cantSwitch'. Either include it or remove the dependency array
|
|
lint:
packages/web-extension-did/app/web/pages/My/useMenuList.tsx#L117
React Hook useMemo has an unnecessary dependency: 'deviceAmount'. Either exclude it or remove the dependency array
|
|
lint:
packages/web-extension-did/app/web/pages/Send/components/ToAddressInput/index.tsx#L217
React Hook useEffect has a missing dependency: 'checkAddress'. Either include it or remove the dependency array
|
|
lint:
packages/web-extension-did/app/web/pages/Send/index.tsx#L1429
React Hook useMemo has a missing dependency: 'chainId'. Either include it or remove the dependency array
|
|
lint:
packages/web-extension-did/app/web/pages/Token/Custom/index.tsx#L165
React Hook useCallback has an unnecessary dependency: 'isPrompt'. Either exclude it or remove the dependency array
|
|
lint:
packages/mobile-app-did/babel.config.js#L2
'getAliasesFromTsConfig' is defined but never used
|
|
lint:
packages/mobile-app-did/jest.config.js#L9
Strings must use singlequote
|
|
lint:
packages/mobile-app-did/js/Test/GoogleTest/index.ios.tsx#L24
Expected { after 'if' condition
|
|
lint:
packages/mobile-app-did/js/Test/ReactNativeElement.tsx#L67
Inline style: { width: 200, marginHorizontal: 50, marginVertical: 10 }
|
|
lint:
packages/mobile-app-did/js/Test/Test.tsx#L67
Inline style: { width: 200, marginHorizontal: 50, marginVertical: 10 }
|
|
lint:
packages/mobile-app-did/js/api/utils.ts#L31
Expected { after 'if' condition
|
|
lint:
packages/mobile-app-did/js/assets/image/generateSvg.js#L13
Expected { after 'if' condition
|
|
lint:
packages/mobile-app-did/js/assets/image/getSvg.js#L11
Expected { after 'if' condition
|
|
lint:
packages/mobile-app-did/js/assets/image/getSvg.js#L23
Expected { after 'if' condition
|
|
lint:
packages/mobile-app-did/js/components/AppListener/index.tsx#L25
Expected { after 'if' condition
|