-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Files and Batches as a unified route #862
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VisargD
reviewed
Jan 14, 2025
VisargD
reviewed
Jan 14, 2025
VisargD
reviewed
Jan 16, 2025
VisargD
reviewed
Jan 16, 2025
VisargD
previously approved these changes
Jan 16, 2025
narengogi
changed the title
Feature Files and Batches
Feature: Files and Batches as a unified route
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues: (optional)
Feature to add batches and files as a unified route
This add the following routes:
POST
/v1/files
GET
/v1/files
GET
/v1/files/:fileId
DELETE
/v1/files/:fileId
POST
/v1/batches
GET
/v1/batches
GET
/v1/batches/:batchId
POST
/v1/batches/:batchId/cancel
✨ Gateway specific additional route for convenience (Not in OpenI spec) ✨
GET
/v1/batches/:batchId/output
Description
For file uploads, the gateway needs to transform files to the provider format (like bedrock) on the fly, the files can be as large as 20GB, this implementation does not load the files into memory, rather it transforms the data streams on the fly with nodeJS streams and pushes to the other endpoint with a half duplex connection.
Similar streaming transformers for getting batch output and getting files is implemented, where the file stream is transformed on the fly
I've had to upgrade wrangler version for nodeJS compatibility to add Polyfill support for nodeJS crypto module which is used for signing the AWS requests, although the gateway has
@smithy/signature-v4
package installed, I wasn't able to get it to work for the s3 file upload routes, I'll have to revisit thisTesting done
top
command on my machineTO-DO for later
@smithy/signature-v4
package without having to write all the signing code ourselves, or alternatively we can remove the smithy signing package and implement the functions ourselves