Add NovitaAI Provider #303
Conversation
|
Updated the README. @VisargD can review the PR. |
| getEndpoint: ({ fn }) => { | ||
| switch (fn) { | ||
| case 'complete': | ||
| return '/v1/completions'; |
There was a problem hiding this comment.
end point seems to be incorrect.
please refer to https://novita.ai/get-started/llm.html#example-with-curl-client
There was a problem hiding this comment.
Hi it's correct, we use the /v3/openai prefix, so the complete URL will be /v3/openai/v1/completion
There was a problem hiding this comment.
The final url as mentioned in the documentation is https://api.novita.ai/v3/openai/completions
But the above configuration will result in final url being https://api.novita.ai/v3/openai/v1/completions
Nothing in the documentation mentions /v1 being needed
There was a problem hiding this comment.
hey! I noticed that both https://api.novita.ai/v3/openai/v1/completions and https://api.novita.ai/v3/openai/completions are behaving similarly. But the novita's official documentation does not mention https://api.novita.ai/v3/openai/v1/completions being the end point as mentioned here https://novita.ai/get-started/llm.html#example-with-curl-client. Can you remove the /v1 so that it is compliant with their official documentation?
|
Hey @AnyISalIn . Thanks for the PR! Please find the changes requested in comments above. Please let me know if you need any additional details |
done, can you review again ? |
| getEndpoint: ({ fn }) => { | ||
| switch (fn) { | ||
| case 'complete': | ||
| return '/v1/completions'; |
There was a problem hiding this comment.
hey! I noticed that both https://api.novita.ai/v3/openai/v1/completions and https://api.novita.ai/v3/openai/completions are behaving similarly. But the novita's official documentation does not mention https://api.novita.ai/v3/openai/v1/completions being the end point as mentioned here https://novita.ai/get-started/llm.html#example-with-curl-client. Can you remove the /v1 so that it is compliant with their official documentation?
|
@sk-portkey, thank you for your excellent code review. I have fixed these issues and hope that you can review it again. |
|
looks good to me |
|
@sk-portkey Hello, when can we merge? |
|
Hey @AnyISalIn - Can you please resolve the merge conflicts? |
It has been fixed |
|
Hey @AnyISalIn - We are merging few other PRs as well. So that caused a merge conflict again. Can you please resolve it again. I will merge the PR asap so no other conflicts occur. Sorry for the inconvenience. |
can you checking again ? |
|
The conflicts were not resolved properly. All the markers of the conflict are still in code. Can you please check them? Please let me know if you need any help. |
Signed-off-by: AnyISalIn <[email protected]>
|
Closes #330 |
Add NovitaAI Provider:
NovitaAI is an AI API platform that offers the most favorable pricing for open-source LLM models.