Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build instructions for macOS are fairly out of date. This PR updates build docs in the following ways:
#
comments which break the newline escaping of thecmake
command. I have moved these comments to bullet points above thecmake
command.openjdk@17
with homebrew, binaries and includes are not added to the environment by default. Instead of adding symlinks we can just use these twoexport
commands for the build step.cmake
flags-DCMAKE_OSX_DEPLOYMENT_TARGET=10.14
which will not compile becausestd::filesystem::path
was introduced in 10.15-S
and-B
flags-j4
to themake install
step.-j4
means.