Refac & Fix: Refactoring Code And Fix Code #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Train0303
commented
Feb 16, 2024
Train0303
commented
- 현재 FCM 코드에 수신이 제대로 동작하지 않아 상세한 로그를 추가해봤습니다.
- 필요없는 코드들을 제거하고 리팩토링 했습니다.
- 중복되는 로그 코드를 제거했습니다.
- JobParameter를 사용하지 않는 상황에서 @Stepscope를 사용할 이유가 없고, 메모리 적으로 싱글톤 빈을 등록하는 것이 좋아보여 제거했습니다.
- 테스트 용으로 로그 코드를 추가했습니다.
- 사용하지 않는 코드 삭제
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.