Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPT-1545 fix signage request issue #394

Merged
merged 3 commits into from
Oct 18, 2024
Merged

PPT-1545 fix signage request issue #394

merged 3 commits into from
Oct 18, 2024

Conversation

naqvis
Copy link
Contributor

@naqvis naqvis commented Oct 17, 2024

No description provided.

Copy link

Hey, your PR is titled PPT-1545 fix signage request issue.
This is not a valid conventional commit.
Since we use well-formed PR titles for our changelogs, not fixing this can introduce problems :'(

Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stakach stakach merged commit c1de4fd into master Oct 18, 2024
8 of 11 checks passed
@stakach stakach deleted the PPT-1545 branch October 18, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants