refactor(storage): stop extending stdlib hash #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspiano
force-pushed
the
refactor/mixin-hash
branch
from
bad0314 to
42b35ad
Compare
|
|
caspiano
force-pushed
the
refactor/mixin-hash
branch
from
42b35ad to
82d07a7
Compare
kimburgess
reviewed
Apr 29, 2021
Co-authored-by: Kim Burgess <[email protected]>
|
Following up on the comments by Kim, the hash should be storing JSON strings. |
stakach
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending stdlib interfaces is generally frowned upon by the crystal community.
In this case, this PR is a step towards unblocking sentry integration.
Includes a small optimisation to
RedisStorage#to_hSee PlaceOS/rest-api/pull/89 and the referenced Raven.cr issue