-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fall damage and /kill #959
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I have gathered you do nothing on the client side. The client-side only informs the server that some damage happened.
This might be fine on its own, since health really isn't something where you necessarily need low latency, but it definitely goes against the intended use case of the InventoryCommands, which are designed to do client-side prediction with server-side validation.
If you only really need SyncOperations and a way to inform the server that the client received fall damage, then you really shouldn't define a BaseOperation and an InventoryCommand at all. You can just use a regular protocol to inform the server of the fall damage amount, and then just execute addHealth from there (which would then just lock the mutex, update the player health, and then send the sync operation back)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks for working on this.
And thanks for splitting the PR, this really made reviewing a lot more pleasant.
No description provided.