Skip to content

Commit

Permalink
- Version bumped
Browse files Browse the repository at this point in the history
- Fix: Create theme dialog now working again (GitHub-ID field was added)
  • Loading branch information
Grav-IntelliJ-Plugin committed Mar 8, 2020
1 parent 8cd95e4 commit a9928a9
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 7 deletions.
9 changes: 9 additions & 0 deletions resources/META-INF/plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,15 @@
]]></description>

<change-notes><![CDATA[
<p>
<span>0.5.2</span>
<ul>
<li>Bugfix</li>
<ul>
<li>Create theme dialog now working again (GitHub-ID field was added)</li>
</ul>
</ul>
</p>
<p>
<span>0.5.0/0.5.1</span>
<ul>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,6 @@ public void actionPerformed(AnActionEvent e) {
final Project project = CommonDataKeys.PROJECT.getData(dataContext);
final Module module = LangDataKeys.MODULE.getData(dataContext);
final IdeView view = LangDataKeys.IDE_VIEW.getData(dataContext);

ProjectChecker.checkProject(project);


if (view == null) {
return;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public NewThemeData getThemeData() {
protected ValidationInfo doValidate() {
if (dialog.textField1.getText().isEmpty()) {
return new ValidationInfo("Please specify a name for the new theme", dialog.textField1);
} else if(dialog.textField2.getText().isEmpty() || dialog.textField3.getText().isEmpty() || dialog.textField4.getText().isEmpty()) {
} else if(dialog.textField2.getText().isEmpty() || dialog.textField3.getText().isEmpty() || dialog.textField4.getText().isEmpty() || dialog.textField5.getText().isEmpty()) {
return new ValidationInfo("Please fill out all empty fields", dialog.textField1);
}
return super.doValidate();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public class CreateThemeDialog extends JDialog implements CaretListener {
public JTextField textField2;
public JTextField textField3;
public JTextField textField4;
private JTextField textField5;
public JTextField textField5;

private NewThemeData themeData = new NewThemeData();

Expand Down Expand Up @@ -47,7 +47,7 @@ public void caretUpdate(CaretEvent e) {
if (e.getSource() == textField4) {
themeData.setEmail(textField4.getText());
}
if (e.getSource() == textField4) {
if (e.getSource() == textField5) {
themeData.setGitHubId(textField5.getText());
}
}
Expand Down

0 comments on commit a9928a9

Please sign in to comment.