-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cd): update docker image repo and dockerfiles for devbuild job #3335
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: wuhuizuo <[email protected]>
Based on the pull request changes, the following key changes have been made:
Potential Problems:
Fixing Suggestions:
|
/approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
New changes are detected. LGTM label has been removed. |
/unhold |
/hold |
include hotfix build and common dev build. Signed-off-by: wuhuizuo <[email protected]>
New changes are detected. LGTM label has been removed. |
/unhold PTAL again |
This pull request includes significant changes to the
jenkins/pipelines/cd/dev-build.groovy
file to improve the mapping and retrieval of Docker image URLs and Dockerfile URLs. The most important changes include the introduction of a new mapping for Docker image repositories, updates to the Dockerfile URL retrieval logic, and adjustments to the image naming conventions.Improvements to Docker image and Dockerfile mappings:
jenkins/pipelines/cd/dev-build.groovy
: IntroducedDockerImgRepoMapping
to map products to their respective Docker image repositories. This replaces the previousDockerMapping
and expands the coverage to include more products.jenkins/pipelines/cd/dev-build.groovy
: Updated theget_dockerfile_url
function to use a more comprehensive mapping for retrieving Dockerfile URLs based on the product and version. The new mapping covers both versions >= 'v6.6.0' and < 'v6.6.0'.Adjustments to image naming conventions:
jenkins/pipelines/cd/dev-build.groovy
: Changed theProductForDocker
assignment to useDockerImgRepoMapping
instead of the oldDockerMapping
. This ensures consistency with the new Docker image repository mapping.jenkins/pipelines/cd/dev-build.groovy
: Modified the image naming logic for hotfixes to remove theqa
prefix from the image repository path.