Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cd): update docker image repo and dockerfiles for devbuild job #3335

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Jan 31, 2025

This pull request includes significant changes to the jenkins/pipelines/cd/dev-build.groovy file to improve the mapping and retrieval of Docker image URLs and Dockerfile URLs. The most important changes include the introduction of a new mapping for Docker image repositories, updates to the Dockerfile URL retrieval logic, and adjustments to the image naming conventions.

Improvements to Docker image and Dockerfile mappings:

  • jenkins/pipelines/cd/dev-build.groovy: Introduced DockerImgRepoMapping to map products to their respective Docker image repositories. This replaces the previous DockerMapping and expands the coverage to include more products.
  • jenkins/pipelines/cd/dev-build.groovy: Updated the get_dockerfile_url function to use a more comprehensive mapping for retrieving Dockerfile URLs based on the product and version. The new mapping covers both versions >= 'v6.6.0' and < 'v6.6.0'.

Adjustments to image naming conventions:

@ti-chi-bot ti-chi-bot bot requested a review from purelind January 31, 2025 14:31
Copy link

ti-chi-bot bot commented Jan 31, 2025

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request changes, the following key changes have been made:

  • The DockerMapping dictionary has been renamed to DockerImgRepoMapping
  • DockerImgRepoMapping has been updated to include new image repositories and their Dockerfiles.
  • The ProductForDocker variable has been updated to use the DockerImgRepoMapping dictionary instead of the DockerMapping dictionary.

Potential Problems:

  • The missing comma in line 44 of DockerImgRepoMapping may cause a syntax error in the script.
  • It is unclear from the pull request description what prompted the changes in the pull request, making it difficult to understand the reasoning behind the changes.

Fixing Suggestions:

  • Add a comma to line 44 of DockerImgRepoMapping to avoid a syntax error.
  • Update the pull request description to give more context about the changes and the problem they are solving.

@ti-chi-bot ti-chi-bot bot added the size/L label Jan 31, 2025
@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Feb 5, 2025

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Feb 5, 2025
@wuhuizuo wuhuizuo added lgtm and removed approved labels Feb 5, 2025
@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Feb 5, 2025

/approve

Copy link

ti-chi-bot bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 5, 2025
@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Feb 5, 2025

/hold

@ti-chi-bot ti-chi-bot bot removed the lgtm label Feb 5, 2025
Copy link

ti-chi-bot bot commented Feb 5, 2025

New changes are detected. LGTM label has been removed.

@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Feb 6, 2025

/unhold

@purelind
Copy link
Collaborator

purelind commented Feb 6, 2025

/hold

include hotfix build and common dev build.

Signed-off-by: wuhuizuo <[email protected]>
@ti-chi-bot ti-chi-bot bot removed the lgtm label Feb 6, 2025
Copy link

ti-chi-bot bot commented Feb 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-05 08:01:53.695965173 +0000 UTC m=+258785.228377170: ✖️🔁 reset by wuhuizuo.
  • 2025-02-06 12:46:32.503296816 +0000 UTC m=+362264.035708814: ✖️🔁 reset by wuhuizuo.

Copy link

ti-chi-bot bot commented Feb 6, 2025

New changes are detected. LGTM label has been removed.

@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Feb 6, 2025

/unhold

PTAL again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants