add dialogs when admins edit other users #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The refetch function still isn't doing what it's supposed to, but I'll make that a separate PR. This solves the one change. |
calebeby
reviewed
Jun 10, 2023
varCepheid
added
needs work
varCepheid
removed
the
needs work
calebeby
added
the
needs work
varCepheid
removed
the
needs work
|
@calebeby I made the change you requested. It seems like you didn't mark your comments as a review, so I can't request a new review from you. |
calebeby
reviewed
Nov 12, 2023
@varCepheid Do you want to remove the refetch-related changes from this PR since it looks like it still isn't working? |
calebeby
reviewed
Nov 12, 2023
There was a problem hiding this comment.
@varCepheid This is excellent! Super impressed! I left two tiny bits of feedback, but this is just about ready to go!
varCepheid
added
the
needs work
varCepheid
removed
the
needs work
Thank you!
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
* created a dialog on editing EditableTexts by admins in user * refresh the user page after every change * switched to standard system of getting DB info for users * Revert "switched to standard system of getting DB info for users" This reverts commit 1c5a09e. * changed all self props to isCurrentUser * separated alertOnSaveAdmin function, small changes * changed selfEdit to isCurrentUser and removed all refetch changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1094
When an admin or super-admin edits the name, username, or password of another user, the app should create a dialog to confirm the change. The dialog shouldn't be created if the user is editing their own profile.