Port pinhole camera from ROS1 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bilal Gill <[email protected]>
henrygerardmoore
commented
Oct 7, 2024
Comment on lines
+16
to
+17
| -cppcoreguidelines-pro-bounds-constant-array-index, | ||
| -cppcoreguidelines-pro-bounds-pointer-arithmetic, |
There was a problem hiding this comment.
These two are annoying in test code and with Eigen in general.
henrygerardmoore
commented
Oct 7, 2024
| -google-readability-casting, | ||
| -google-default-arguments, |
There was a problem hiding this comment.
There is a core class that uses a default argument that a ton of stuff inherits from (the print method in fuse models) so changing all these would be annoying.
henrygerardmoore
commented
Oct 7, 2024
| -misc-include-cleaner, | ||
| -misc-non-private-member-variables-in-classes, |
There was a problem hiding this comment.
Purely stylistic one that I don't care for. False positives on structs too, for which you obviously want public member variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Must merge after #2