Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7cb590a.
Here I come back tucking my tail between my legs. We wrote install interface tests and even did some manual testing with this new RSL version in the wild using projects that depend on RSL. We found no issues so we felt comfortable shipping. Alas something about the Debian packaging of RSL results in an
rsl::rsl
target which seemingly lacks the correct interface install directories or interface link libraries resulting in numerous build failures.We're unsure why this is the case or why any of this is happening or whether adding
ament
back will even fix anything.