Temporary fix for linuxfs-i2c IOException. Also fix return code for … #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ytes read readRegister.
eitch
approved these changes
Mar 15, 2024
| @@ -330,8 +330,6 @@ public int writeReadRegisterWord(int register, int word) { | |||
| reg[1] = (byte) (word & 0xff); | |||
| reg[2] = (byte) ((word >> 8) & 0xff); | |||
| byte buff[] = new byte[2]; | |||
|
|
|||
| int rCode = this.readRegister(reg, buff, 0, buff.length); | |||
There was a problem hiding this comment.
Why did you remove this readRegister?
| @@ -56,6 +56,8 @@ public synchronized I2C create(I2CConfig config) { | |||
| LinuxFsI2CBus i2CBus = this.i2CBusMap.computeIfAbsent(config.getBus(), busNr -> new LinuxFsI2CBus(config)); | |||
| // create new I/O instance based on I/O config | |||
| LinuxFsI2C i2C = new LinuxFsI2C(i2CBus, this, config); | |||
| // Workaround, needed if first LinuxFsI2C usage is ioctl (readRegister or writeRegister) | |||
| i2C.read(); | |||
There was a problem hiding this comment.
Is there not an init of a buffer in this method, which then makes the ioctl work?
There was a problem hiding this comment.
For instance i can see this:
this.lastAddress = i2c.device();
this.file.ioctl(I2CConstants.I2C_SLAVE, i2c.device() & 0xFF);
so the very first thing that happens, is that we set the lastAddress, then immediately perform an ioctl... So maybe this is missing?
There was a problem hiding this comment.
ok, i do see that the readRegister() does this too...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…bytes read readRegister.
See issue #335 for a complete description of the problem and temporary fix.