[stable fix] Catch broken files before the autorotate call #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blefaudeux
force-pushed
the
ben/img_close
branch
2 times, most recently
from
d37aad2 to
099d2ee
Compare
blefaudeux
force-pushed
the
ben/img_close
branch
6 times, most recently
from
11b6342 to
d9a07f9
Compare
- now reproed the issue, looks like it's around the autorotate part - fixing this hopefully
blefaudeux
force-pushed
the
ben/img_close
branch
from
d9a07f9 to
a4b06bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
turns out that img.AutoRotate() from govips (calling vips) can hard crash on ill formated files, if the number of channels is not specified properly (it will read/rotate/write the buffer, kind of makes sense).
Now sanitizing the image before calling it, seems to have fixed stability issues