Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support refreshrates other than 60 #314

Merged
merged 7 commits into from
Apr 6, 2024
+11 −4
Merged

feat: Support refreshrates other than 60 #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ad593a7
feat: Support refreshrates other than 60
ShootingKing-AM Mar 31, 2024
a76cf2c
rebase
ShootingKing-AM Mar 31, 2024
4fa9540
lint fix
ShootingKing-AM Mar 31, 2024
93391cd
Revert "lint fix"
ShootingKing-AM Mar 31, 2024
346c211
lint errors
ShootingKing-AM Mar 31, 2024
520c474
Update ALVR
ShootingKing-AM Mar 31, 2024
a9f4a59
Update ALVR to v20.6.2
ShootingKing-AM Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code/mobile/android/PhoneVR/app/src/main/cpp/alvr_main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,14 +171,14 @@ void inputThread() {
// }

extern "C" JNIEXPORT void JNICALL Java_viritualisres_phonevr_ALVRActivity_initializeNative(
JNIEnv *env, jobject obj, jint screenWidth, jint screenHeight) {
JNIEnv *env, jobject obj, jint screenWidth, jint screenHeight, jfloat refreshRate) {
CTX.javaVm = jVM;
CTX.javaContext = env->NewGlobalRef(obj);

uint32_t viewWidth = std::max(screenWidth, screenHeight) / 2;
uint32_t viewHeight = std::min(screenWidth, screenHeight);

float refreshRatesBuffer[1] = {60.f};
float refreshRatesBuffer[1] = {refreshRate};

alvr_initialize((void *) CTX.javaVm,
(void *) CTX.javaContext,
Expand Down
11 changes: 9 additions & 2 deletions code/mobile/android/PhoneVR/app/src/main/java/viritualisres/phonevr/ALVRActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import android.provider.Settings;
import android.util.DisplayMetrics;
import android.util.Log;
import android.view.Display;
import android.view.MenuInflater;
import android.view.MenuItem;
import android.view.View;
Expand Down Expand Up @@ -97,7 +98,12 @@ public void onCreate(Bundle savedInstance) {
int width = displayMetrics.widthPixels;
int height = displayMetrics.heightPixels;

initializeNative(width, height);
// get refresh rate of the device
Display display = getWindowManager().getDefaultDisplay();
float refreshRate = display.getRefreshRate();
Log.i(TAG, "Refresh rate: " + refreshRate);

initializeNative(width, height, refreshRate);

setContentView(R.layout.activity_vr);
glView = findViewById(R.id.surface_view);
Expand Down Expand Up @@ -248,7 +254,8 @@ private void setImmersiveSticky() {
| View.SYSTEM_UI_FLAG_IMMERSIVE_STICKY);
}

private native void initializeNative(int screenWidth, int screenHeight);
private native void initializeNative(
int screenWidth, int screenHeight, float screenRefreshRate);

private native void destroyNative();

Expand Down
Loading