Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Simple Fix] Draw visual effects for airburst weapons #1466

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

CrimRecya
Copy link
Contributor

  • AirburstWeapon now supports IsLaser (with Ares LaserThickness), IsElectricBolt (with Phobos Bolt.Disable1, Bolt.Disable2, Bolt.Disable3, Bolt.Arcs, without Ares Bolt.Color1Bolt.Color2Bolt.Color3), IsRadBeam (with Ares Beam.ColorBeam.DurationBeam.AmplitudeBeam.IsHouseColor), and AttachedParticleSystem.

Copy link

github-actions bot commented Dec 28, 2024

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Copy link
Contributor

@Coronia Coronia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again I would like some comments about how the position in SimulatedFiringAnim is calculated. If someone else reading the codes, they might be confused by the algorithm or magic number in it

@CrimRecya CrimRecya requested a review from Coronia February 20, 2025 07:13
Copy link
Contributor

@Coronia Coronia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the current code only used SimulatedFiringEffects for once with firingEffect set to false, which means that SimulatedFiringAnim and SimulatedFiringReport are actually omitted. Is this the intended way? If so, then where should these functions be used?

@CrimRecya
Copy link
Contributor Author

the current code only used SimulatedFiringEffects for once with firingEffect set to false, which means that SimulatedFiringAnim and SimulatedFiringReport are actually omitted. Is this the intended way? If so, then where should these functions be used?

Disperse and Tracing trajectory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants