-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Simple Fix] Draw visual effects for airburst weapons #1466
base: develop
Are you sure you want to change the base?
[Simple Fix] Draw visual effects for airburst weapons #1466
Conversation
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again I would like some comments about how the position in SimulatedFiringAnim
is calculated. If someone else reading the codes, they might be confused by the algorithm or magic number in it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the current code only used SimulatedFiringEffects
for once with firingEffect
set to false, which means that SimulatedFiringAnim
and SimulatedFiringReport
are actually omitted. Is this the intended way? If so, then where should these functions be used?
|
AirburstWeapon
now supportsIsLaser
(with AresLaserThickness
),IsElectricBolt
(with PhobosBolt.Disable1
,Bolt.Disable2
,Bolt.Disable3
,Bolt.Arcs
, without AresBolt.Color1
、Bolt.Color2
、Bolt.Color3
),IsRadBeam
(with AresBeam.Color
、Beam.Duration
、Beam.Amplitude
、Beam.IsHouseColor
), andAttachedParticleSystem
.