[Framework] Rework Extras draw #1422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
|
Why? |
To reduce PR number. I'm currently unavailable to work on this subject, more specifically properly dehardcoding stuff and design ini structure, which might require constant feedback and discussion. Meanwhile people might be impatient for things like #1287 #1309 etc. The common issue here and in the current digital display is the overhead, like the same draw point being calculated multiple times. Similar overhead also exists in vanilla code, if you don't use gdi ddraw you might not notice. Will resume later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everyone (e.g. #1287 #1309 #1395 #1418 #1148) is doing their own work separately and creating overhead and incompatibilities.
As we've stated before the entire Healthbar drawing system needs to be overwritten completely.
This settles the framework for all these.
TODO: