Add ability to link fiscal sponsors to changemaker #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to link fiscal sponsors to changemaker
A fiscal sponsor in PDC terms is another changemaker. To add a fiscal
sponsor to a changemaker, call the new endpoint `PUT
/changemakers/{changemakerId}/fiscalSponsors/{fiscalSponsorChangemakerId}`
To remove the relationship, call the corresponding `DELETE` endpoint.
The `GET /changemakers/{changemakerId}` endpoint now returns a list of
fiscal sponsors. The list is composed of shallow changemakers to avoid
a technical issue of potential infinite recursion. So the caller will
not see the `fields` or `fiscalSponsors` within the `fiscalSponsors`
returned by `GET /changemakers/{changemakerId}`. To get the detailed
data on a changemaker, simply call the same `GET` with the sponsor ID.
There is some ambiguity about whether this explicitly modeled
fiscal sponsorship relationship in PDC is intended to be only current
relationships or both current and past relationships. Assume for now
that it is both current and past, reserving `DELETE` for mistaken data
entry.
Circular sponsorship graphs are supported but not direct
self-sponsorship cycles.
Issue #1485 Support fiscal sponsor relationships between changemakers
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1490 +/- ##
==========================================
- Coverage 86.89% 85.49% -1.41%
==========================================
Files 235 238 +3
Lines 2931 2998 +67
Branches 402 418 +16
==========================================
+ Hits 2547 2563 +16
- Misses 384 435 +51 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fiscal sponsor in PDC terms is another changemaker. To add a fiscal sponsor to a changemaker, call the new endpoint
PUT /changemakers/{changemakerId}/fiscalSponsors/{fiscalSponsorChangemakerId}To remove the relationship, call the correspondingDELETEendpoint.The
GET /changemakers/{changemakerId}endpoint now returns a list of fiscal sponsors. The list is composed of shallow changemakers to avoid a technical issue of potential infinite recursion. So the caller will not see thefieldsorfiscalSponsorswithin thefiscalSponsorsreturned byGET /changemakers/{changemakerId}. To get the detailed data on a changemaker, simply call the sameGETwith the sponsor ID.There is some ambiguity about whether this explicitly modeled fiscal sponsorship relationship in PDC is intended to be only current relationships or both current and past relationships. Assume for now that it is both current and past, reserving
DELETEfor mistaken data entry.Circular sponsorship graphs are supported but not direct self-sponsorship cycles.
Issue #1485 Support fiscal sponsor relationships between changemakers