Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on PDC data permissions #1474

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

bickelj
Copy link
Contributor

@bickelj bickelj commented Jan 31, 2025

Issue #1291

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.89%. Comparing base (ff39cb2) to head (63f78d7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1474   +/-   ##
=======================================
  Coverage   86.89%   86.89%           
=======================================
  Files         213      213           
  Lines        2633     2633           
  Branches      345      345           
=======================================
  Hits         2288     2288           
  Misses        315      315           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bickelj bickelj force-pushed the 1291-add-permissions-overview branch from 7c7871e to 53775c2 Compare February 1, 2025 12:33
Copy link
Member

@slifty slifty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really really good thank you for documenting it so clearly.

I had one question about the semantic linking between keycloak organization and funder / changemaker / data provider in the PDC. If there is no use case for that right now we might consider removing it from the documentation entirely to make it clearer that the way you assign permissions to members of a keycloak organization is via PDC userGroups

docs/PERMISSIONS.md Show resolved Hide resolved
@bickelj bickelj force-pushed the 1291-add-permissions-overview branch from 53775c2 to eefb061 Compare February 4, 2025 15:51
@bickelj bickelj force-pushed the 1291-add-permissions-overview branch from eefb061 to 63f78d7 Compare February 4, 2025 21:20
@bickelj bickelj merged commit 9a4eaaf into main Feb 4, 2025
11 checks passed
@bickelj bickelj deleted the 1291-add-permissions-overview branch February 4, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants