Skip to content

Commit

Permalink
Merge pull request #659 from PhilanthropyDataCommons/log-task-errors
Browse files Browse the repository at this point in the history
  • Loading branch information
jasonaowen authored Dec 21, 2023
2 parents cf8e5bc + 0efd1a6 commit c72e79b
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
10 changes: 5 additions & 5 deletions src/jobQueue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,19 @@ export const jobQueueLogger = new Logger((scope) => (
(level, message, meta) => {
switch (level.valueOf()) {
case 'error':
logger.error({ meta, scope }, message);
logger.error({ ...meta, scope }, message);
break;
case 'warn':
logger.warn({ meta, scope }, message);
logger.warn({ ...meta, scope }, message);
break;
case 'info':
logger.info({ meta, scope }, message);
logger.info({ ...meta, scope }, message);
break;
case 'debug':
logger.debug({ meta, scope }, message);
logger.debug({ ...meta, scope }, message);
break;
default:
logger.info({ meta, scope }, message);
logger.info({ ...meta, scope }, message);
}
}
));
Expand Down
8 changes: 4 additions & 4 deletions src/tasks/processBulkUpload.ts
Original file line number Diff line number Diff line change
Expand Up @@ -366,17 +366,17 @@ export const processBulkUpload = async (
},
));
});
} catch (error) {
helpers.logger.info('Bulk upload is being marked as failed', { error });
} catch (err) {
helpers.logger.info('Bulk upload is being marked as failed', { err });
await updateBulkUploadStatus(bulkUpload.id, BulkUploadStatus.FAILED);
return;
}
try {
await bulkUploadFile.cleanup();
} catch (error) {
} catch (err) {
helpers.logger.warn(
`Cleanup of a temporary file failed (${bulkUploadFile.path})`,
{ error },
{ err },
);
}
await updateBulkUploadStatus(bulkUpload.id, BulkUploadStatus.COMPLETED);
Expand Down

0 comments on commit c72e79b

Please sign in to comment.