-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflect change in CPAN releasor #22926
Conversation
On CPAN Time-Piece has a new release from a new releasor. For consistent results out of 'Porting/core-cpan-diff', we should have changed the CPANID of the releasor in Maintainers.pl before synching. We'll correct that here and standardize all $VERSIONs in cpan/Time-Piece to indicate we're now a bit ahead of CPAN.
I don't get why we need to bump these all to an _01 version. Is it not sufficient simply to change the user ID in Maintainers.pl? I was slightly surprised that it didn't update that when I ran |
It might be "sufficient" with respect to getting the porting tests to DWIM. But if we were to do that, at some point in the future someone would ask, "Why is the version number in Maintainers.pl different from that in the code?" I think our criterion here should be "What will cause the least confusion going forward?" (I acknowledge that some may feel the criterion should be "What entails the fewest changed keystrokes.)
This is a small flaw with |
With this PR, the data in The version number in |
Yes, I think we could live with that. |
Looks like @steve-m-hay fixed this in ecb78df so likely this PR can be closed now? It seems I forgot to remove the lines out of |
Yes. |
On CPAN Time-Piece has a new release from a new releasor. For consistent results out of 'Porting/core-cpan-diff', we should have changed the CPANID of the releasor in Maintainers.pl before synching. We'll correct that here and standardize all $VERSIONs in cpan/Time-Piece to indicate we're now a bit ahead of CPAN.