Introduced an API to collect the core from an unrelated process #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlevon
suggested changes
Dec 2, 2024
jlevon
suggested changes
Dec 9, 2024
| /* If pid belong to the one called the library no need to proceed */ | ||
| if (expid == 0 && pid == clone_pid) continue; | ||
|
|
||
| strcat(strcpy(fname, "/proc/"), entry->d_name); |
jlevon
suggested changes
Dec 10, 2024
jlevon
approved these changes
Jan 9, 2025
The API WriteCoreDumpOfPID() will take argument pid, and try to collect the core from the process with pid, this uses the existing logic to identify the threads under the given process and to identify the maps and the properties of each memory maps. Then read the memory content from /proc/[pid]/mem, we assume that the caller has the permission to trace and read the mem from process [pid]. A tool also introduced, which will use the API WriteCoreDumpOfPID and provide a convenient CLI for the user, which will help in creating core dump of any process that the user has permission to trace. Following is the help from the tool: Usage: ./coredumper_tool <-c corefile> <-p pid> [-s core_size] [-z] <-h> Show this message and exit <-c core_file> Collect the core dump into a file core_file <-p pid> Collect the core dump of process with pid <-s core_size> Limit the size of core_file to core_size <-z> Compress the core_file on the fly with gzip
ramkums
force-pushed
the
coredumper_tool
branch
from
7cc27b0 to
dd17672
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API WritePidCoreDumpWith() will take argument pid, and try to collect the core from the process with pid, this uses the existing logic to identify the threads under the given process and to identify the maps and the properties of each memory maps. Then read the memory content from /proc/[pid]/mem, we assume that the caller has the permission to trace and read the mem from process [pid].
A tool also introduced, which will use the API WritePidCoreDumpWith and provide a convenient CLI for the user, which will help in creating core dump of any process that the user has permission to trace.