Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix docs] Fix shadow module TOC #6955

Merged
merged 7 commits into from
Feb 13, 2025
Merged

[bugfix docs] Fix shadow module TOC #6955

merged 7 commits into from
Feb 13, 2025

Conversation

Qottmann
Copy link
Contributor

@Qottmann Qottmann commented Feb 12, 2025

Came up in a separate PR, fixing a bug in the docs of the TOC in the shadows module

I compared it with the fermi module description and made the structure

  • overview
    • measurements
    • etc
  • descriptions etc.

see module page in preview vs. current version

before:

image

after:
image

Also added some cosmetic changes like putting a one-line description in the overview

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@Qottmann Qottmann mentioned this pull request Feb 12, 2025
5 tasks
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.59%. Comparing base (9068353) to head (6370676).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6955   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files         480      480           
  Lines       45651    45651           
=======================================
  Hits        45466    45466           
  Misses        185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Qottmann Qottmann requested a review from josh146 February 12, 2025 22:22
Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Qottmann! I don't quite understand why splitting it up between two different files affects the title hierarchy :(

I guess ideally the documentation lives in the __init__.py file, since then it is closer to the code/developers who change the code remember to update it

Copy link
Contributor

@dwierichs dwierichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Qottmann
Copy link
Contributor Author

Thanks @Qottmann! I don't quite understand why splitting it up between two different files affects the title hierarchy :(

I guess ideally the documentation lives in the init.py file, since then it is closer to the code/developers who change the code remember to update it

Good point! I think the problem was actually that the overview headline was in the rst file. I moved now everything to the init, including the overview headline, and it seems fine. I also prefer to have it closer to the code! Now the fix is also easier

looks good to me
image

@Qottmann Qottmann enabled auto-merge (squash) February 13, 2025 16:57
@Qottmann Qottmann merged commit 95736c0 into master Feb 13, 2025
46 checks passed
@Qottmann Qottmann deleted the fixshadowtoc branch February 13, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants