-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix docs] Fix shadow module TOC #6955
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6955 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 480 480
Lines 45651 45651
=======================================
Hits 45466 45466
Misses 185 185 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Qottmann! I don't quite understand why splitting it up between two different files affects the title hierarchy :(
I guess ideally the documentation lives in the __init__.py
file, since then it is closer to the code/developers who change the code remember to update it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Good point! I think the problem was actually that the overview headline was in the rst file. I moved now everything to the init, including the overview headline, and it seems fine. I also prefer to have it closer to the code! Now the fix is also easier |
Came up in a separate PR, fixing a bug in the docs of the TOC in the shadows module
I compared it with the fermi module description and made the structure
see module page in preview vs. current version
before:
after:

Also added some cosmetic changes like putting a one-line description in the overview