[WIP] Lowering Ion dialect to llvm dialect #1466
Open
+694
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will take a look once I get back! @joeycarter can also fill you in on the ion op semantics if they feel unclear |
4 tasks
paul0403
reviewed
Jan 24, 2025
| @@ -0,0 +1,187 @@ | |||
| // Copyright 2024 Xanadu Quantum Technologies Inc. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2024 Xanadu Quantum Technologies Inc. | |
| // Copyright 2025 Xanadu Quantum Technologies Inc. |
paul0403
reviewed
Jan 24, 2025
| @@ -0,0 +1,58 @@ | |||
| // Copyright 2024 Xanadu Quantum Technologies Inc. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2024 Xanadu Quantum Technologies Inc. | |
| // Copyright 2025 Xanadu Quantum Technologies Inc. |
|
Hello. You may have forgotten to update the changelog!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
So far, as part of the ion dialect pass infrastructure, we have the ion decomposition pass which genreates a universal gate set of (RX,RY, MS). This gate set would be lowered to ion dialect which consists of IonOp, PulseOp and ParallelProtocolOp operations and IonType. we need to lower the ion dialect operations into llvm stubs which will be used in runtime to generate machine related instructions.
Description of the Change:
--convert-ion-to-llvmBenefits:
This PR would enable runtime to capture the ion dialect related instructions.
Possible Drawbacks:
Related GitHub Issues:
[sc-79342]