Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cubids print-metadata-fields exits if no dataset_desciption.json #409

Merged
merged 1 commit into from
Jan 17, 2025
Merged

cubids print-metadata-fields exits if no dataset_desciption.json #409

merged 1 commit into from
Jan 17, 2025

Conversation

singlesp
Copy link
Contributor

Closes #198.

Changes proposed in this pull request

  • cubids print-metadata-fields checks for dataset_description.json in bids_dir and exits if not found. This address a bug where it would run for a long time if passed a non-existent dataset.

tsalo
tsalo approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tsalo tsalo added the bug Something isn't working label Jan 17, 2025
@singlesp singlesp merged commit 07c0947 into main Jan 17, 2025
10 checks passed
@singlesp singlesp deleted the check-for-dataset-desctiption branch January 17, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsalo tsalo tsalo approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cubids-print-metadata-fields runs for a long time if you pass in a non-existent dataset
2 participants
@singlesp @tsalo