fix: update HEX_REGEX to allow spaces and new lines

PeculiarVentures · Nov 22, 2024 · 8331891 · 8331891
1 parent ba25aa9
commit 8331891
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/convert.ts b/src/convert.ts
@@ -8,7 +8,7 @@ declare function atob(data: string): string;
 
 const STRING_TYPE = "string";
 
-const HEX_REGEX = /^[0-9a-f]+$/i;
+const HEX_REGEX = /^[0-9a-f\s]+$/i;
 const BASE64_REGEX = /^(?:[A-Za-z0-9+/]{4})*(?:[A-Za-z0-9+/]{2}==|[A-Za-z0-9+/]{3}=)?$/;
 const BASE64URL_REGEX = /^[a-zA-Z0-9-_]+$/;
 

diff --git a/test/convert.ts b/test/convert.ts
@@ -77,6 +77,10 @@ describe("Convert", () => {
       const hex = Convert.ToHex(buf);
       assert.strictEqual(hex, "010203");
     });
+    it("decode with space and new line chars", () => {
+      const buf = Convert.FromHex(" 01\n02\r03 04\n");
+      assert.strictEqual(buf.byteLength, 4);
+    });
   });
 
   context("utf16", () => {
@@ -129,6 +133,9 @@ describe("Convert", () => {
     it("wrong", () => {
       assert.strictEqual(Convert.isHex("1234567890ABCDEF!"), false);
     });
+    it("spaces and new lines", () => {
+      assert.strictEqual(Convert.isHex("1234\n5678 90AB\rCDEF"), true);
+    });
   });
 
   context("isBase64", () => {