-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototype for storing single-cell data #1020
base: development
Are you sure you want to change the base?
Conversation
9222a95
to
788a61b
Compare
gemma-core/src/test/java/ubic/gemma/persistence/util/ListUtilsTest.java
Outdated
Show resolved
Hide resolved
f04ae2f
to
d791771
Compare
...va/ubic/gemma/persistence/service/expression/experiment/ExpressionExperimentServiceImpl.java
Outdated
Show resolved
Hide resolved
.../main/java/ubic/gemma/persistence/service/expression/experiment/ExpressionExperimentDao.java
Show resolved
Hide resolved
gemma-core/src/main/java/ubic/gemma/model/expression/bioAssayData/DataVector.java
Outdated
Show resolved
Hide resolved
...-core/src/main/resources/ubic/gemma/model/expression/designElement/CompositeSequence.hbm.xml
Outdated
Show resolved
Hide resolved
b60a8de
to
0ce142a
Compare
80c6409
to
e804d92
Compare
b2c8a8b
to
6a993b7
Compare
b7d4810
to
7c29995
Compare
I'm in the process of merging the dev branch to get this work up-to-date. |
@@ -130,6 +130,13 @@ | |||
<!-- cannot be non-null because subsets and generic experiments don't have curation details --> | |||
<column name="CURATION_DETAILS_FK" not-null="false" sql-type="BIGINT" unique="true"/> | |||
</many-to-one> | |||
<set name="singleCellExpressionDataVectors" lazy="true" fetch="select" inverse="true" | |||
cascade="all-delete-orphan"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove the -delete-orphan
and manage vectors the same way we do for raw and processed ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That include bulk insertion, removal, etc.
Move classes that analyzes single-cell data in ubic.gemma.core.analysis.singleCell. Extract logic that converts data from different scale type.
Don't require -qtName to be supplied and in the case of no set of vectors matching exactly the one being imported, find one by name.
Add a new interface BioAssaySetValueObject and use it in the code so that we don't assume that an ExpressionExperimentSubsetValueObject derives from an ExpressionExperimentValueObject. Reintroduce the DoubleVectorValueObject cache. Since we're not caching processed vector in Hibernate anymore, this now make sense to do. Make sure that operations on ProcessedExpressionDataVectorService evict the vectors and vectors by gene caches. Make sure that we create copies when setting a minimum P-value or rank on a vector as to not contaminate the content of the cache. Ideally, those models should be immutable. Regenerate the DWR client code as we're adding a new model.
Add an ExpressionDataPrimitiveDoubleMatrix interface to provide unboxed doubles from bulk and single-cell data matrices. Rename DoubleSingleCellExpressionDataMatrix to SingleCellExpressionDataDoubleMatrix for consistency with other matrix names.
Make sure that services are transient in tags.
TODO
SingleCellExpresionDataMatrix
, we need to finish the work and write it to file). I think MEX is a pretty decent output format for this.REST API