This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Add the PlayerXpEvent events (add XP points/level, pickup XP orb) #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheGlitch76
suggested changes
Jun 18, 2020
patchwork-events-entity/src/main/java/net/minecraftforge/event/entity/player/PlayerXpEvent.java
Outdated
Show resolved
Hide resolved
...events-entity/src/main/java/net/patchworkmc/mixin/event/entity/MixinExperienceOrbEntity.java
Show resolved
Hide resolved
TheGlitch76
suggested changes
Jun 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for Curios, See #84.
I can't remember if it is in Forge, but I've marked
PlayerPickupXpEventas deprecated as it's removed in Forge for 1.15. It seems to have been the original event for interacting with XP pickups, until it was superseded by thePlayerXpEventfamily of events.When
PlayerXpEvent.XpChangeis cancelled, there is a very small behavioural difference to Forge:PlayerEntity.addScore(with zero as an argument) andPlayerEntity.getNextLevelExperienceare called. The former callsgetandseton a DataTracker, the latter doesn't call any other methods (and while other mods hookinggetNextLevelExperienceis plausible, one would expect those not to have any side-effects).Since a
@ModifyVariablemixin is used, it's not (as far as I know) straightforward to also properly cancel this event, though of course it can be done if you think it might make a difference.