This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
ItemTooltipEvent #108
Merged
ItemTooltipEvent #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheGlitch76
reviewed
Jul 5, 2020
|
|
||
| @Mixin(ItemStack.class) | ||
| public class MixinItemStack { | ||
| @Inject(method = "getTooltip", at = @At("RETURN"), locals = LocalCapture.PRINT) |
There was a problem hiding this comment.
Looks like this can be removed?
| @@ -20,7 +20,8 @@ | |||
| "client": [ | |||
| "MixinClientWorld", | |||
| "MixinClientPlayerEntity", | |||
| "MixinOtherClientPlayerEntity" | |||
| "MixinOtherClientPlayerEntity", | |||
| "MixinItemStack" | |||
| private final List<Text> toolTip; | ||
|
|
||
| /** | ||
| * This event is fired in {@link ItemStack#getTooltip(PlayerEntity, TooltipContext)}, which in turn is called from it's respective GUIContainer. |
|
Checkstyle needs fixed |
|
CI seems to have failed due to a timeout when fetching from fabric's maven. Built locally, seems to be fine. |
TheGlitch76
approved these changes
Jul 19, 2020
You can manually trigger a re-run on the checks if this happens. ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes a part of #84.