Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

romanizing channel names #3

Open
wants to merge 5 commits into
base: romanize-channel-names
Choose a base branch
from

Conversation

Megunight
Copy link
Contributor

@Megunight Megunight commented May 1, 2024

Closes #2

19 is weird piano
60 is weird
66 is weird cuz chinese
77 is weird cuz is producer
@pinapelz pinapelz marked this pull request as ready for review May 2, 2024 03:50
@pinapelz pinapelz self-requested a review May 2, 2024 03:50
@pinapelz pinapelz changed the base branch from main to romanize-channel-names May 2, 2024 03:53
@pinapelz pinapelz force-pushed the romanize-channel-names branch from 6ab2a2e to aca3742 Compare May 2, 2024 04:10
@pinapelz
Copy link
Member

pinapelz commented May 2, 2024

Yeah there's some videos that slip through the crack (doesn't fit the scope of the project), that ends up leading to some random channels having rows in the table.

But some of them do have MVs so they need to be individually checked. Just skip them when unsure.

For other languages like Chinese or other languages go for Japanese romanization unless they don't have it

@Megunight
Copy link
Contributor Author

Yeah there's some videos that slip through the crack (doesn't fit the scope of the project), that ends up leading to some random channels having rows in the table.

But some of them do have MVs so they need to be individually checked. Just skip them when unsure.

For other languages like Chinese or other languages go for Japanese romanization unless they don't have it

aye aye captain o7

@Megunight Megunight changed the title romanized til line 97 closes #2 May 2, 2024
@Megunight Megunight changed the title closes #2 romanizing channel names May 2, 2024
187 is weird not vtuber
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Romanize names in channels table
2 participants